Re: [Xen-devel] xen: aarch64: is this just typo?

[Ian Campbell <Ian.Campbell@xxxxxxxxxx>]

On Wed, 2013-12-04 at 22:27 +0800, Dennis Lan (dlan) wrote:
> On Wed, Dec 4, 2013 at 8:34 PM, Ian Campbell <Ian.Campbell@xxxxxxxxxx> wrote:
> > On Wed, 2013-12-04 at 20:19 +0800, Dennis Lan (dlan) wrote:
> >>
> >> 2013 12/4 5:52ï"Ian Campbell" <Ian.Campbell@xxxxxxxxxx>ï
> >> >
> >> > On Wed, 2013-12-04 at 14:43 +0800, Dennis Lan (dlan) wrote:
> >> > > run through the code, and found this, possible this is just a typo
> >> > > (copy and paste)?
> >> > > just wondering...
> >> >
> >> > Yes, I think it is. Well spotted.
> >> >
> >> > http://wiki.xen.org/wiki/Submitting_Xen_Patches describes how to
> >> submit
> >> > a patch to Xen. Given this is so trivial however if you just provide
> >> me
> >> > with your Signed-off-by in this thread I'll throw a commit message
> >> on it
> >> > and check it in.
> >> >
> >> > Thanks.
> >> >
> >> hi Ian
> >> I will submit a more formal patch next timeïbut not this time..
> >> and this is really trivial patchïjust feel free to commit
> >
> > I'd still prefer to do so with your Signed-off-by. As I said before you
> > can just state it here, no need to resubmit a formal patch.
> >
> > Ian.
> >
> HI Ian:
>   Ok, I didn't make it clear myself, I thought you can directly commit
> without adding my signed-off, since it's really trivial change..
>   but if you want, you can add "Signed-off-by: Lan Yixun (dlan)
> <dennis.yxun@xxxxxxxxx>"
>   Thanks again.

Every change needs a signed-off-by of some sort. Now perhaps/probably I
could have just added my own but iwth yours I don't even have to think
about whether that is OK.

Anyhow, thanks I have applied the following.

Ian

commit c04fbf58558de544b96c861bb88293524fa30afc
Author: Dennis Lan (dlan) <dennis.yxun@xxxxxxxxx>
Date:   Wed Dec 4 14:37:25 2013 +0000

    xen: arm64: clear boot_first instead of boot_pgtable twice
    
    Signed-off-by: Lan Yixun (dlan) <dennis.yxun@xxxxxxxxx>
    Acked-by: Ian Campbell <ian.campbell@xxxxxxxxxx>

diff --git a/xen/arch/arm/mm.c b/xen/arch/arm/mm.c
index e6753fe..399e546 100644
--- a/xen/arch/arm/mm.c
+++ b/xen/arch/arm/mm.c
@@ -470,7 +470,7 @@ void __init setup_pagetables(unsigned long 
boot_phys_offset, paddr_t xen_paddr)
     memset(boot_pgtable, 0x0, PAGE_SIZE);
     flush_xen_dcache(boot_pgtable);
 #ifdef CONFIG_ARM_64
-    memset(boot_pgtable, 0x0, PAGE_SIZE);
+    memset(boot_first, 0x0, PAGE_SIZE);
     flush_xen_dcache(boot_first);
 #endif
     memset(boot_second, 0x0, PAGE_SIZE);



_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
http://lists.xen.org/xen-devel