Re: [Xen-devel] [PATCH v2 4/6] arm: add a function to invoke the PSCI handler

[Ian Campbell <Ian.Campbell@xxxxxxxxxx>]

On Wed, 2013-12-04 at 13:25 +0100, Andre Przywara wrote:
> On 12/02/2013 04:07 PM, Ian Campbell wrote:
> > On Mon, 2013-12-02 at 12:08 +0100, Andre Przywara wrote:
> >> The PSCI handler is invoked via a secure monitor call with the
> >> arguments defined in registers. Copy the function from the
> >> Linux code and adjust it to work on both ARM32 and ARM64.
> >>
> >> Signed-off-by: Andre Przywara <andre.przywara@xxxxxxxxxx>
> >> ---
> >>   xen/arch/arm/psci.c        | 28 ++++++++++++++++++++++++++++
> >>   xen/include/asm-arm/psci.h |  1 +
> >>   2 files changed, 29 insertions(+)
> >>
> >> diff --git a/xen/arch/arm/psci.c b/xen/arch/arm/psci.c
> >> index 9ff06cd..cc382be 100644
> >> --- a/xen/arch/arm/psci.c
> >> +++ b/xen/arch/arm/psci.c
> >> @@ -25,8 +25,36 @@
> >>
> >>   int psci_available;
> >>
> >> +#ifdef CONFIG_ARM_32
> >> +#define REG_PREFIX "r"
> >> +#else
> >> +#define REG_PREFIX "x"
> >> +#endif
> >> +
> >> +static noinline int __invoke_psci_fn_smc(u32 function_id, u32 arg0, u32 
> >> arg1,
> >> +                                         u32 arg2)
> >
> > I should reread the PSCI spec, but are these not 64-bit on AArch64?
> 
> Indeed. Not for all functions and parameters, but for the start address 
> at least that makes sense ;-)
> Is there a type in Xen which reliably holds a native word? ulong or 
> something?

You can use vaddr_t or register_t depending on the semantics (they are
otherwise the same). Probably register_t here.


Ian.


_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
http://lists.xen.org/xen-devel