Re: [Xen-devel] [PATCH] xen/pvhvm: If xen_platform_pci=0 is set don't blow up.

[Stefano Stabellini <stefano.stabellini@xxxxxxxxxxxxx>]

On Tue, 3 Dec 2013, Konrad Rzeszutek Wilk wrote:
> diff --git a/arch/x86/xen/platform-pci-unplug.c 
> b/arch/x86/xen/platform-pci-unplug.c
> index 0a78524..087dfeb 100644
> --- a/arch/x86/xen/platform-pci-unplug.c
> +++ b/arch/x86/xen/platform-pci-unplug.c
> @@ -69,6 +69,24 @@ static int check_platform_magic(void)
>       return 0;
>  }
>  
> +bool xen_has_pv_devices(void)
> +{
> +     if (!xen_domain())
> +             return false;
> +
> +     if (xen_hvm_domain()) {
> +             /* User requested no unplug, so no PV drivers. */
> +             if (xen_emul_unplug & XEN_UNPLUG_NEVER)
> +                     return false;

Considering that if (xen_emul_unplug & XEN_UNPLUG_NEVER) we never set
xen_platform_pci_unplug, this check is redundant.


> +             /* And user has xen_platform_pci=0 set in guest config as
> +              * driver did not modify the value. */
> +             if (!xen_platform_pci_unplug)
> +                     return false;
> +     }
> +     return true;
> +}
> +EXPORT_SYMBOL_GPL(xen_has_pv_devices);
> +
>  void xen_unplug_emulated_devices(void)
>  {
>       int r;

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
http://lists.xen.org/xen-devel