Re: [Xen-devel] [V4 PATCH 6/7] pvh dom0: Add and remove foreign pages

[Ian Campbell <Ian.Campbell@xxxxxxxxxx>]

On Tue, 2013-12-03 at 17:05 -0800, Mukesh Rathor wrote:
> On Wed, 04 Dec 2013 00:00:54 +0000
> Julien Grall <julien.grall@xxxxxxxxxx> wrote:
> 
> > 
> > 
> > On 12/03/2013 02:30 AM, Mukesh Rathor wrote:
> > > In this patch, a new function, xenmem_add_foreign_to_pmap(), is
> > > added
> > 
> > xenmem_add_foreign_to_p2m?
> > 
> > > to map pages from foreign guest into current dom0 for domU creation.
> > > Such pages are typed p2m_map_foreign. Also, support is added here to
> > > XENMEM_remove_from_physmap to remove such pages. Note, in the remove
> > > path, we must release the refcount that was taken during the map
> > > phase.
> > 
> > Your remove path is very interesting for the ARM port. For now we are 
> > unable to unmap the foreign page because get_page() will always
> > return NULL (as dom0 is not the owner).
> > 
> > I will give a try on ARM to see if it could resolve our problem.
> > 
> 
> Don't know much about ARM, is the remove path failing to compile on it?
> You can submit ARM modification patch after it's checked in?

No, we don't break things like this even transiently.

You can find an ARM cross compiler at
https://launchpad.net/linaro-toolchain-binaries/+download and cross
building just the hypervisor part is pretty trivial.

Please make sure the ARM side at least compiles, probably by defining
the macros which you introduce to have fixed values which equate to the
current behaviour.

Ian.


_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
http://lists.xen.org/xen-devel