Re: [Xen-devel] [PATCH V7] ns16550: Add support for UART present in Broadcom TruManage capable NetXtreme chips

[Ian Campbell <Ian.Campbell@xxxxxxxxxx>]

On Tue, 2013-12-03 at 10:40 -0600, Aravind Gopalakrishnan wrote:
> Since it is an MMIO device, the code has been modified to accept MMIO based
> devices as well. MMIO device settings are populated in the 'uart_config' 
> table.
> It also advertises 64 bit BAR. Therefore, code is reworked to account for 64
> bit BAR and 64 bit MMIO lengths.
> 
> Some more quirks are - the need to shift the register offset by a specific
> value and we also need to verify (UART_LSR_THRE && UART_LSR_TEMT) bits before
> transmitting data.
> 
> While testing, include com1=115200,8n1,pci,0 on the xen cmdline to observe
> output on console using SoL.
> 
> Changes from V6:
>   - per Jan's comments:
>     - Use bool_t for enable_ro
>     - Reword comment
>     - Use printk instead of WARN()
>     - Use either pci_ro_device or pci_hide_device, not both.
> 
> Signed-off-by: Aravind Gopalakrishnan <Aravind.Gopalakrishnan@xxxxxxx>
> Signed-off-by: Suravee Suthikulpanit <Suravee.Suthikulpanit@xxxxxxx>
> Signed-off-by: Thomas Lendacky <Thomas.Lendacky@xxxxxxx>

Build testing this on 32-bit arm resulted in a buch of warnings about
trailing whitespace from git am and:
        ns16550.c: In function âns16550_initâ:
        ns16550.c:879:9: error: âstruct ns16550â has no member named âenable_roâ
        ns16550.c: At top level:
        ns16550.c:100:78: error: âuart_configâ defined but not used 
[-Werror=unused-variable]
        cc1: all warnings being treated as errors

The hypervisor is pretty easy to cross compile, compilers are available
from https://launchpad.net/linaro-toolchain-binaries and then
        make XEN_TARGET_ARCH=arm32 CROSS_COMPILE=arm-blah-blah- xen -jN
similarly for arm64.


_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
http://lists.xen.org/xen-devel