Re: [Xen-devel] [PATCH net v2] xen-netback: clear vif->task on disconnect

[Wei Liu <wei.liu2@xxxxxxxxxx>]

On Tue, Dec 03, 2013 at 02:06:25PM +0000, Paul Durrant wrote:
> xenvif_start_xmit() relies on checking vif->task for NULL to determine
> whether the vif is ready to accept packets. The task thread is stopped in
> xenvif_disconnect() but task is not set to NULL. Thus, on a re-connect the
> check will give a false positive.
> 
> Also since commit ea732dff5cfa10789007bf4a5b935388a0bb2a8f (Handle backend
> state transitions in a more robust way) it should not be possible for
> xenvif_connect() to be called if the vif is already connected so change the
> check of vif->tx_irq to a BUG_ON() and also add a BUG_ON(vif->task).
> 
> Signed-off-by: Paul Durrant <paul.durrant@xxxxxxxxxx>
> Cc: Wei Liu <wei.liu2@xxxxxxxxxx>
> Cc: Ian Campbell <ian.campbell@xxxxxxxxxx>
> Cc: David Vrabel <david.vrabel@xxxxxxxxxx>

Acked-by: Wei Liu <wei.liu2@xxxxxxxxxx>

Thanks
Wei.

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
http://lists.xen.org/xen-devel