[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index] Re: [Xen-devel] [PATCH v5 12/17] xen/libxc: sched: DOMCTL_*vcpuaffinity works with hard and soft affinity
On mar, 2013-12-03 at 12:08 +0100, Dario Faggioli wrote: > On mar, 2013-12-03 at 10:06 +0000, Jan Beulich wrote: > > And just to make it explicit - with fundamental flaws like this, I'm > > not certain anymore whether we really ought to rush this series > > in for 4.4. > > > Well, I certainly have no intention to say that this isn't something > that I overlooked. Just for the sake of completeness, that's what's > required to fix it: > > diff --git a/xen/common/domctl.c b/xen/common/domctl.c > index 9eecb5e..cd817f3 100644 > --- a/xen/common/domctl.c > +++ b/xen/common/domctl.c > @@ -661,7 +661,7 @@ long do_domctl(XEN_GUEST_HANDLE_PARAM(xen_domctl_t) > u_domctl) > { > ret = xenctl_bitmap_to_bitmap(cpumask_bits(new_affinity), > &vcpuaff->cpumap_hard, > - vcpuaff->cpumap_hard.nr_bits); > + nr_cpu_ids); > if ( !ret ) > ret = vcpu_set_hard_affinity(v, new_affinity); > if ( ret ) > @@ -679,7 +679,7 @@ long do_domctl(XEN_GUEST_HANDLE_PARAM(xen_domctl_t) > u_domctl) > { > ret = xenctl_bitmap_to_bitmap(cpumask_bits(new_affinity), > &vcpuaff->cpumap_soft, > - vcpuaff->cpumap_soft.nr_bits); > + nr_cpu_ids); > if ( !ret) > ret = vcpu_set_soft_affinity(v, new_affinity); > if ( ret ) > BTW, there's a v6 with this fixed, as well as other Jan's (coding style and explaining interface in public headers) and IanC's (about code motion) comments addressed: git://xenbits.xen.org/people/dariof/xen.git numa/per-vcpu-affinity-v6 http://xenbits.xen.org/gitweb/?p=people/dariof/xen.git;a=shortlog;h=refs/heads/numa/per-vcpu-affinity-v6 Just waiting a bit more to post it, to see if there are other comments. Regards, Dario -- <<This happens because I choose it to happen!>> (Raistlin Majere) ----------------------------------------------------------------- Dario Faggioli, Ph.D, http://about.me/dario.faggioli Senior Software Engineer, Citrix Systems R&D Ltd., Cambridge (UK) <<This happens because I choose it to happen!>> (Raistlin Majere) ----------------------------------------------------------------- Dario Faggioli, Ph.D, http://about.me/dario.faggioli Senior Software Engineer, Citrix Systems R&D Ltd., Cambridge (UK) Attachment:
signature.asc _______________________________________________ Xen-devel mailing list Xen-devel@xxxxxxxxxxxxx http://lists.xen.org/xen-devel
|
Lists.xenproject.org is hosted with RackSpace, monitoring our |