Re: [Xen-devel] [PATCH v3] Nested VMX: CR emulation fix up

["Jan Beulich" <JBeulich@xxxxxxxx>]

>>> On 03.12.13 at 11:09, "Egger, Christoph" <chegger@xxxxxxxxx> wrote:
> On 03.12.13 08:54, Yang Zhang wrote:
>> --- a/xen/include/asm-x86/hvm/vcpu.h
>> +++ b/xen/include/asm-x86/hvm/vcpu.h
>> @@ -110,6 +110,9 @@ struct nestedvcpu {
>>       */
>>      bool_t nv_ioport80;
>>      bool_t nv_ioportED;
>> +
>> +    /* L2's control-resgister, just as the L2 sees them. */
>> +    unsigned long       guest_cr[5];
>>  };
> 
> I have a question to everyone thinking the nv_ prefix is pointless:
> Did you ever read BSD code?

No, I didn't. Using such prefixes is a relic of the K&R days.

Jan


_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
http://lists.xen.org/xen-devel