Re: [Xen-devel] [PATCH v4 13/15] xl: enable getting and setting soft

[Ian Campbell <Ian.Campbell@xxxxxxxxxx>]

On Tue, 2013-12-03 at 12:14 +0100, Dario Faggioli wrote:
> On mar, 2013-12-03 at 10:59 +0000, Ian Campbell wrote:
> > On Tue, 2013-12-03 at 11:27 +0100, Dario Faggioli wrote:
> > > On mar, 2013-12-03 at 09:32 +0000, Ian Campbell wrote:
> > > > Another option would be to take two affinities on the command line, the
> > > > first being hard and the second soft with some special syntax ("-"?) for
> > > > "leave it alone".
> > > > 
> > > Mmm... I think I like this better. So, if we take the approach
> > > implemented in this patch right now, and introduce something like that
> > > later, here's what we'd get:
> > > 
> > >  1. xl vcpu-pin 3 all 4-6 : hard affinity for all dom3 vcpus --> 4-6
> > 
> > You mean soft don't you? And also hard -> all, not left alone.
> > 
> Aha! :-) Actually, the 'all' here (and below) refers to "what dom3's
> vcpu(s)"?
> 
>  xl vcpu-pin <OPTIONS> <domain-id> <vcpu> <cpus>
> 
> So, no, I did mean hard and, more specifically, I included that example
> because that is what is being used right now (and I mean _right_now_ so
> before this series), and that we both agreed should continue working.

Oh, yes I was confused by the all for the vcpu field.

> Now that you made me thinking about this, going this way we risk to have
> something like:
> 
>  xl vcpu-pin 3 all all all
> 
> which may not exactly look crystal-clear...

It's a bit odd isn't it, but I think livable with.

> > >  2. xl vcpu-pin -s 3 all 3,5 : soft affinity for all dom3 vcpus --> 3,5
> > 
> > I think if you give -s then you should expect only one cpumap, which
> > would be the soft affinity map.
> > 
> Same here. Another example could be:
> 
>  xl vcpu-pin -s 3 0 3,5
> 
> which has indeed only one cpumap, "3,5", while the "0" means vcpu #0
> doma domain 3.
> 
> > > Would that be ok?
> > 
> > I like it.
> > 
> So, is this still true? :-D

Yes. All IMHO of course -- would be nice to hear what others think.

Ian.



_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
http://lists.xen.org/xen-devel