Re: [Xen-devel] [V3 PATCH 4/9] dom0: construct_dom0 changes

["Jan Beulich" <JBeulich@xxxxxxxx>]

>>> On 27.11.13 at 03:27, Mukesh Rathor <mukesh.rathor@xxxxxxxxxx> wrote:
> This patch changes construct_dom0 to boot in PVH mode. Changes
> need to support it are also included here.
> 
> Signed-off-by: Mukesh Rathor <mukesh.rathor@xxxxxxxxxx>

Looks mostly okay, except ...

> @@ -1089,8 +1264,15 @@ int __init construct_dom0(
>      regs->eflags = X86_EFLAGS_IF;
>  
>      if ( opt_dom0_shadow )
> +    {
> +        if ( is_pvh_domain(d) )
> +        {
> +            printk("Invalid option dom0_shadow for PVH\n");

... this option isn't invalid, it's merely unsupported iiuc.

> +void __init hap_set_pvh_alloc_for_dom0(struct domain *d,
> +                                       unsigned long num_pages)
> +{
> +    int rc;
> +    unsigned long memkb = num_pages * (PAGE_SIZE / 1024);
> +
> +   /* Copied from: libxl_get_required_shadow_memory() */

Indentation.

> +    memkb = 4 * (256 * d->max_vcpus + 2 * (memkb / 1024));
> +    num_pages = ((memkb+1023)/1024) << (20 - PAGE_SHIFT);

Missing blanks around operators.

Jan


_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
http://lists.xen.org/xen-devel