Re: [Xen-devel] [PATCH 10/13] libxl: don't try to fclose file twice on error in libxl_userdata_store

[Ian Jackson <Ian.Jackson@xxxxxxxxxxxxx>]

Matthew Daley writes ("[PATCH 10/13] libxl: don't try to fclose file twice on 
error in libxl_userdata_store"):
> Do this by changing the function to not use stdio file operations, but
> just use write(2) directly.

This is not correct.  If you use write(2) directly you have to call it
in a loop, in case of partial writes.  This is quite tiresome.  I
think it would be better to simply fix the function not to "retry" the
fclose if it fails the first time.

> While at it, tidy up the function's style issues.

This makes the result very hard to review.  It is better to split
nonfunctional changes out into their own patch.

Ian.

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
http://lists.xen.org/xen-devel