Re: [Xen-devel] [PATCH net-next] xen-netback: improve guest-receive-side flow control

[David Vrabel <david.vrabel@xxxxxxxxxx>]

On 28/11/13 13:11, Paul Durrant wrote:
> The flow control code relies on a double pass of tke skb, firstly to count
> the number of ring slots needed to supply sufficient grant references, and
> another to actually consume those references and build the grant copy
> operations. It transpires that, in some scenarios, the initial count and the
> number of references consumed differs and, after this happens a number of
> times, flow control is completely broken.

Can you describe in more detail the cases where it gets it wrong?

> -unsigned int xenvif_count_skb_slots(struct xenvif *vif, struct sk_buff *skb)

Any patch that gets rid of this gets my vote (provided it works!).

Can you list all the guest frontends that you've tested this with?

David

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
http://lists.xen.org/xen-devel