[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Xen-devel] [PATCH] nested vmx: fix I/O port bitmap indexing arithmetic



>>> On 29.11.13 at 23:38, Matthew Daley <mattd@xxxxxxxxxxx> wrote:
> The I/O port bitmap holds 8 ports per element, and hence the port number
> used when indexing into it should be shifted right by 3 bits, not 4.
> 
> Signed-off-by: Matthew Daley <mattd@xxxxxxxxxxx>
> ---
> Jan: I'm not sure if this also needs a fixup similar to what you did in
> SVM code with commit b1e87805bf.

Yes, definitely. The wrapping behavior is different for VMX though.
In fact, I'd prefer the whole fix to be done in one go (unless you
tell me that you're not going to find time to do so any time soon).

Jan


_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
http://lists.xen.org/xen-devel


 


Rackspace

Lists.xenproject.org is hosted with RackSpace, monitoring our
servers 24x7x365 and backed by RackSpace's Fanatical Support®.