Re: [Xen-devel] [PATCH 04/13] libxl: don't leak p in libxl__wait_for_backend

[Matthew Daley <mattd@xxxxxxxxxxx>]

On Mon, Dec 2, 2013 at 12:53 AM, Andrew Cooper
<andrew.cooper3@xxxxxxxxxx> wrote:
> On 01/12/2013 10:14, Matthew Daley wrote:
>> Coverity-ID: 1055891
>> Signed-off-by: Matthew Daley <mattd@xxxxxxxxxxx>
>
> As with my " tools/libxl: Fix libxl__device_nic_from_xs_be()" patch, I
> feel the suggestion will be to use libxl__xs_read_checked() instead,
> given all the libxl GC machinery already around.

Good point, I didn't notice it was allocated by xs_read in the first
place. I was holding back on such cases with the intent to produce one
big patch to convert all xs_reads in libxl to their GC'd counterparts,
but since I still haven't done this, and since it makes sense to
individually patch the ones that are leaking their results right now,
I'll make a v2.

- Matthew

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
http://lists.xen.org/xen-devel