Re: [Xen-devel] [PATCH v2-resend 22/30] libxl: ocaml: event management [and 1 more messages]

[Rob Hoes <Rob.Hoes@xxxxxxxxxx>]

Ian Jackson wrote:
> Sent: 28 November 2013 4:47 PM
> To: Rob Hoes; xen-devel@xxxxxxxxxxxxx; Ian Campbell
> Subject: Re: [Xen-devel] [PATCH v2-resend 22/30] libxl: ocaml: event
> management [and 1 more messages]
> 
> Ian Jackson writes ("Re: [Xen-devel] [PATCH v2-resend 22/30] libxl: ocaml:
> event management [and 1 more messages]"):
> > > +value stub_libxl_event_register_callbacks(value ctx, value user)
> > ...
> > > + c_user = malloc(sizeof(*c_user));
> > > + c_user->user = (void *) user;
> >
> > Shouldn't you be using some kind of error-handling wrapper for malloc
> > ?  Having the program dereference null when malloc fails is rather an
> > unfortunate failure mode.  At the very least printing something to
> > stderr would be useful.
> 
> There's some more of this in v6.  I don't think it's a blocker for
> inclusion but I thought I'd mention it again since my comment seems to
> have been overlooked.

Yes, sorry, I missed that :(

Thanks,
Rob

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
http://lists.xen.org/xen-devel