Re: [Xen-devel] [PATCH v5 09/12] libxl: ocaml: add some missing CAML macros

[Ian Campbell <Ian.Campbell@xxxxxxxxxx>]

On Wed, 2013-11-27 at 11:47 +0000, Ian Campbell wrote:
> On Tue, 2013-11-26 at 17:52 +0000, Rob Hoes wrote:
> > Signed-off-by: Rob Hoes <rob.hoes@xxxxxxxxxx>
> > CC: Ian Campbell <ian.campbell@xxxxxxxxxx>
> > CC: Ian Jackson <ian.jackson@xxxxxxxxxxxxx>
> > CC: Dave Scott <dave.scott@xxxxxxxxxxxxx>
> > ---
> >  tools/ocaml/libs/xl/xenlight_stubs.c |    7 +++++--
> >  1 file changed, 5 insertions(+), 2 deletions(-)
> > 
> > diff --git a/tools/ocaml/libs/xl/xenlight_stubs.c 
> > b/tools/ocaml/libs/xl/xenlight_stubs.c
> > index 01ba3fe..7012045 100644
> > --- a/tools/ocaml/libs/xl/xenlight_stubs.c
> > +++ b/tools/ocaml/libs/xl/xenlight_stubs.c
> > @@ -58,6 +58,7 @@ static value Val_error (libxl_error error_c);
> >  
> >  static void failwith_xl(int error, char *fname)
> >  {
> > +   CAMLparam0();
> >     CAMLlocal1(arg);
> >     static value *exc = NULL;
> >  
> > @@ -74,6 +75,7 @@ static void failwith_xl(int error, char *fname)
> >     Store_field(arg, 1, caml_copy_string(fname));
> >  
> >     caml_raise_with_arg(*exc, arg);
> > +   CAMLreturn0;
> 
> 
> raise_with_arg has Noreturn, although this is probably harmless enough
> and might keep some stupider compilers happy.

Oops, meant to say: Nonetheless:

Acked-by: Ian Campbell <ian.campbell@xxxxxxxxxx>



_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
http://lists.xen.org/xen-devel