Re: [Xen-devel] [PATCH v5 11/12] libxl: ocaml: remove dead code in xentoollog bindings

[Andrew Cooper <andrew.cooper3@xxxxxxxxxx>]

On 26/11/13 17:52, Rob Hoes wrote:
> Found by Coverty. CIDs: 1128567 1128568 1128576 1128577.
>
> Signed-off-by: Rob Hoes <rob.hoes@xxxxxxxxxx>

Reviewed-by: Andrew Cooper <andrew.cooper3@xxxxxxxxxx>

> ---
>  tools/ocaml/libs/xentoollog/xentoollog_stubs.c |    4 ----
>  1 file changed, 4 deletions(-)
>
> diff --git a/tools/ocaml/libs/xentoollog/xentoollog_stubs.c 
> b/tools/ocaml/libs/xentoollog/xentoollog_stubs.c
> index 87ea53e..46f7f87 100644
> --- a/tools/ocaml/libs/xentoollog/xentoollog_stubs.c
> +++ b/tools/ocaml/libs/xentoollog/xentoollog_stubs.c
> @@ -92,8 +92,6 @@ static void stub_xtl_ocaml_vmessage(struct 
> xentoollog_logger *logger,
>       value *func = caml_named_value(xtl->vmessage_cb) ;
>       char *msg;
>  
> -     if (args == NULL)
> -             caml_raise_out_of_memory();
>       if (func == NULL)
>               caml_raise_sys_error(caml_copy_string("Unable to find 
> callback"));
>       if (vasprintf(&msg, format, al) < 0)
> @@ -123,8 +121,6 @@ static void stub_xtl_ocaml_progress(struct 
> xentoollog_logger *logger,
>       struct caml_xtl *xtl = (struct caml_xtl*)logger;
>       value *func = caml_named_value(xtl->progress_cb) ;
>  
> -     if (args == NULL)
> -             caml_raise_out_of_memory();
>       if (func == NULL)
>               caml_raise_sys_error(caml_copy_string("Unable to find 
> callback"));
>  


_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
http://lists.xen.org/xen-devel