Re: [Xen-devel] [PATCH] fix assert fail in libxl__sigchld_installhandler

[Ian Jackson <Ian.Jackson@xxxxxxxxxxxxx>]

Ian Campbell writes ("Re: [PATCH] fix assert fail in 
libxl__sigchld_installhandler"):
> On Mon, 2013-11-25 at 11:56 +0000, Ian Jackson wrote:
> > From 73b6484cbd5409101308c6c640eb7597f63256b9 Mon Sep 17 00:00:00 2001
> > From: Ian Jackson <ian.jackson@xxxxxxxxxxxxx>
> > Date: Mon, 25 Nov 2013 11:53:28 +0000
> > Subject: [PATCH] libxl: doc comment: clarify SIGCHLD demultiplexing
> >  requirements
> > 
> > Update the comment to clarify that libxl_sigchld_owner_libxl_always
> > implies having only one libxl_ctx, and that
> > libxl_sigchld_owner_mainloop requires one call to
> > libxl_childproc_exited per ctx.
> > 
> > Signed-off-by: Ian Jackson <Ian.Jackson@xxxxxxxxxxxxx>
> 
> Acked-by: Ian Campbell <ian.campbell@xxxxxxxxxx>

I have committed this with the slight clarification below.

Thanks,
Ian.

diff --git a/tools/libxl/libxl_event.h b/tools/libxl/libxl_event.h
index 5b2c689..6261f99 100644
--- a/tools/libxl/libxl_event.h
+++ b/tools/libxl/libxl_event.h
@@ -454,7 +454,8 @@ void libxl_osevent_occurred_timeout(libxl_ctx *ctx, void 
*for_libxl)
  *     libxl_sigchld_owner_libxl_always:
  *       The application expects libxl to reap all of its children,
  *       and provides a callback to be notified of their exit
- *       statues.  The application must have only one libxl_ctx.
+ *       statues.  The application must have only one libxl_ctx
+ *       configured this way.
  *
  * An application which fails to call setmode, or which passes 0 for
  * hooks, while it uses any libxl operation which might

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
http://lists.xen.org/xen-devel