Re: [Xen-devel] [PATCH 0/4] ARM: add PSCI host support

[Ian Campbell <Ian.Campbell@xxxxxxxxxx>]

On Mon, 2013-11-25 at 13:02 +0100, Andre Przywara wrote:
> Xen did not make use of the host provided ARM PSCI (Power State
> Coordination Interface) functionality so far, but relied on platform
> specific SMP bringup functions.
> This series adds support for PSCI on the host by reading the required
> information from the DTB and invoking the appropriate handler when
> bringing up each single CPU.
> Since PSCI is defined for both ARM32 and ARM64, I put the code in a
> file shared by both.
> The ARM32 code was tested on Midway, but the ARM64 code was compile
> tested only.
> 
> This approach seems to be the least intrusive, but one could also use
> more of the current ARM64 code by copying the PSCI/spin-table
> distinction code to a shared file and use that from both
> architectures. However that seems more complicated.

I don't think that is needed (since armv7 spintable vs armv8 spintable
mechanisms are a bit different). But I would like to see the psci code
in a separate psci.c. It's not much code right now but it will likely
grow.

I'll comment a bit more on the individual patches shortly.

Thanks.

Ian.
> 
> Please take a look and complain ;-)
> 
> Signed-off-by: Andre Przywara <andre.przywara@xxxxxxxxxx>
> 
> Andre Przywara (4):
>   arm: parse PSCI node from the host device-tree
>   arm: add a function to invoke the PSCI handler and use it
>   arm: dont give up on EAGAIN if PSCI is defined
>   arm64: defer CPU initialization on ARM64 if PSCI is present
> 
>  xen/arch/arm/arm32/smpboot.c |  1 -
>  xen/arch/arm/arm64/smpboot.c |  7 +++-
>  xen/arch/arm/smpboot.c       | 89 
> +++++++++++++++++++++++++++++++++++++++++---
>  3 files changed, 88 insertions(+), 9 deletions(-)
> 



_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
http://lists.xen.org/xen-devel