Re: [Xen-devel] [PATCH v2 02/15] xen: arm64: Add Basic Platform support for APM X-Gene Storm.

[Ian Campbell <Ian.Campbell@xxxxxxxxxx>]

On Fri, 2013-11-22 at 16:35 +0000, Julien Grall wrote:
> 
> On 11/22/2013 04:24 PM, Ian Campbell wrote:
> > From: Pranavkumar Sawargaonkar <pranavkumar@xxxxxxxxxx>
> >
> > This patch adds initial platform stubs for APM X-Gene.
> >
> > Signed-off-by: Anup Patel <anup.patel@xxxxxxxxxx>
> > Signed-off-by: Pranavkumar Sawargaonkar <pranavkumar@xxxxxxxxxx>
> >
> > Drop earlyprintk (split into earlier patch). Only build on ARM64.
> >
> > Drop empty init and reset hooks and enable 1:1 workaround.
> >
> > Signed-off-by: Ian Campbell <ian.campbell@xxxxxxxxxx>
> > Acked-by: Stefano Stabellini <stefano.stabellini@xxxxxxxxxxxxx>
> > ---
> > v2: Drop empty hooks, merge the 1:1 workaround patch, drop early_printk.h
> > ---
> 
> [..]
> 
> > diff --git a/xen/arch/arm/platforms/xgene-storm.c 
> > b/xen/arch/arm/platforms/xgene-storm.c
> > new file mode 100644
> > index 0000000..727ac2b
> > --- /dev/null
> > +++ b/xen/arch/arm/platforms/xgene-storm.c
> > @@ -0,0 +1,52 @@
> > +/*
> > + * xen/arch/arm/platforms/xgene-storm.c
> > + *
> > + * Applied Micro's X-Gene specific settings
> > + *
> > + * Pranavkumar Sawargaonkar <psawargaonkar@xxxxxxx>
> > + * Anup Patel <apatel@xxxxxxx>
> > + * Copyright (c) 2013 Applied Micro.
> > + *
> > + * This program is free software; you can redistribute it and/or modify
> > + * it under the terms of the GNU General Public License as published by
> > + * the Free Software Foundation; either version 2 of the License, or
> > + * (at your option) any later version.
> > + *
> > + * This program is distributed in the hope that it will be useful,
> > + * but WITHOUT ANY WARRANTY; without even the implied warranty of
> > + * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
> > + * GNU General Public License for more details.
> > + */
> > +
> > +#include <xen/config.h>
> 
> 
> > +#include <xen/device_tree.h>
> > +#include <xen/domain_page.h>
> > +#include <xen/mm.h>
> > +#include <xen/vmap.h>
> 
> Do we really need these 4 includes?

No, leftovers from an incomplete attempt to implement the reset hook
etc. Nuked.

> > +#include <asm/platform.h>
> > +
> > +static uint32_t xgene_storm_quirks(void)
> > +{
> > +    return PLATFORM_QUIRK_DOM0_MAPPING_11;
> > +}
> > +
> > +
> > +static const char const *xgene_storm_dt_compat[] __initdata =
> 
> const char * const ... __initconst

Done.

> Except that:
> Acked-by: Julien Grall <julien.grall@xxxxxxxxxx>

Thanks.

Ian.


_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
http://lists.xen.org/xen-devel