Re: [Xen-devel] [PATCH 13/16] RFC: xen: arm: handle 40-bit addresses in the p2m

[Ian Campbell <Ian.Campbell@xxxxxxxxxx>]

On Thu, 2013-11-21 at 19:17 +0000, Stefano Stabellini wrote:
> On Wed, 20 Nov 2013, Ian Campbell wrote:
> > On the X-gene platform there are resources up this high which must be mapped
> > to dom0.
> > 
> > I'm becoming more convinced that p2m first level pages should be mapped from
> > the xenheap so we can avoid all this faff with figuring out which page is
> > needed.
> > 
> > Remove the first level page from the p2m->pages list since it is actually 
> > two
> > pages and must be freed as such. Do so in p2m_teardown.
> > 
> > I've also punted on the implementation of dump_p2m_lookup for high
> > addresses...
> > 
> > Signed-off-by: Ian Campbell <ian.campbell@xxxxxxxxxx>
> > ---
> > This is a little bit RFC...
> 
> The patch looks good but the commit message is very unclear. It is
> best to clarify what this patch intends to do and then separately what
> could be a future development.

Yeah, it is a bit stream of consciousness isn't it.

I've dropped the paragraph "I'm becoming..." which I think isn't really
necessary in the commit log. I think without that the commit message is
ok, what do you think?



_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
http://lists.xen.org/xen-devel