Re: [Xen-devel] [PATCH v5 16/19] libxc: arm: allow passing a device tree blob to the guest

[Ian Campbell <Ian.Campbell@xxxxxxxxxx>]

On Thu, 2013-11-14 at 00:47 +0000, Julien Grall wrote:
> +        /* Place at 128MB if there is sufficient RAM */
> > +        if (ramend >= rambase + 128*1024*1024 + dtbsize )
> 
> Minor coding style error : if ( ... )

Well spotted

> Also, I'm wondering if (128 << 20) will be more clear?

About the same I think, especially given the preceding comment. I've
left it alone, mostly out of inertia^Wlaziness.

Ian.


_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
http://lists.xen.org/xen-devel