Re: [Xen-devel] [PATCH v3-RESEND 06/28] libxc: ocaml: add simple binding for xentoollog (output only).

[Andrew Cooper <andrew.cooper3@xxxxxxxxxx>]

On 14/11/13 14:11, Rob Hoes wrote:
> IanC wrote:
>> On Mon, 2013-10-21 at 14:32 +0100, Rob Hoes wrote:
>>> [...]
>>> +static void stub_xtl_ocaml_vmessage(struct xentoollog_logger *logger,
>>> +   xentoollog_level level,
>>> +   int errnoval,
>>> +   const char *context,
>>> +   const char *format,
>>> +   va_list al)
>>> +{
>>> +   CAMLparam0();
>>> +   CAMLlocalN(args, 4);
>>> +   struct caml_xtl *xtl = (struct caml_xtl*)logger;
>>> +   value *func = caml_named_value(xtl->vmessage_cb) ;
>>> +   char *msg;
>>> +
>>> +   if (args == NULL)
>>> +           caml_raise_out_of_memory();
>> Coverity is rightly pointing out that an array cannot be NULL. Would you
>> mind fixing as part of the resend of the remainder of this series?
> Sure, I'll fix that.
>
> Andrew Cooper showed me another issue found by Coverity. We have a fix, which 
> I'll submit as well.
>
> Rob

Following our bit of debugging in this area, I notice that the current
series leaves some intermediate files around.

tools/ocaml/libs/xentoollog/_xtl_levels.inc
tools/ocaml/libs/xentoollog/_xtl_levels.ml.in
tools/ocaml/libs/xentoollog/_xtl_levels.mli.in
tools/ocaml/libs/xentoollog/xentoollog.ml
tools/ocaml/libs/xentoollog/xentoollog.mli

When fixing this stuff up, do you mind also modifying
.gitignore/.hgignore for all the intermediate files creates?

~Andrew

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
http://lists.xen.org/xen-devel