Re: [Xen-devel] [PATCH] blkif: add indirect descriptors interface to public headers

[Ian Campbell <ian.campbell@xxxxxxxxxx>]

> diff --git a/xen/include/public/io/protocols.h 
> b/xen/include/public/io/protocols
> index 80b196b..1a3f038 100644
> --- a/xen/include/public/io/protocols.h
> +++ b/xen/include/public/io/protocols.h
> @@ -23,6 +23,10 @@
>  #ifndef __XEN_PROTOCOLS_H__
>  #define __XEN_PROTOCOLS_H__
> 
> +/*
> + * These ABIs are the ones used by GCC. Note that this means 8 byte
> + * values are assumed to be only 4 byte aligned when using x86_32.

Apparently the gcc ABI on x86 is the System V ABI, hence I think these
are the references:
http://www.sco.com/developers/devspecs/abi386-4.pdfâ;
http://www.sco.com/developers/gabi/

I'd suggest putting these into arch-x86.h or somewhere towards the top
level of the headers, since they should apply to all hypercall parameter
structs and not just the I/O interfaces.

Ian.


_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
http://lists.xen.org/xen-devel