Re: [Xen-devel] [PATCH] fix netfront alloc_page error handling bug, need to raise up rx_refill timer if rx request buffer not big enough for backend

[David Vrabel <david.vrabel@xxxxxxxxxx>]

On 14/11/13 02:39, annie li wrote:
> 
> With this assumption, is it easier to fix this issue by moving mod_timer
> directly
>             mod_timer(&np->rx_refill_timer,
>                   jiffies + (HZ/10));
> above
>             if (i != 0)
>                 goto refill;
> 
> in xennet_alloc_rx_buffers?

Yes, always setting the timer if we didn't reach the target is a better
fix I think.

However, we probably want to reduce the fill target if we are under
memory pressure.

Something like:

no_skb:
               /* Memory pressure, reduce fill target. */
               if (--np->rx_target < np->rx_target_min)
                   np->rx_target = np->rx_target_min;
               mod_timer(...);
               goto refill;

perhaps?

David

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
http://lists.xen.org/xen-devel