Re: [Xen-devel] [PATCH V2] xen: Check if the range is valid in init_domheap_pages

[Ian Campbell <Ian.Campbell@xxxxxxxxxx>]

On Wed, 2013-11-13 at 13:26 +0000, Jan Beulich wrote:
> >>> On 13.11.13 at 14:15, Julien Grall <julien.grall@xxxxxxxxxx> wrote:
> > On ARM, when an initrd is given to xen by U-boot, it will reserve the 
> > memory 
> > in the device tree.
> > In this case, when xen decides to free unused memory, dt_unreserved_regions
> > will call init_domheap_pages with the start and the end of range equals. But
> > the latter assumes that (start > end), if not Xen will hang because the
> > number of pages is equals to (unsigned)-1.
> 
> The change is simple enough, so I don't really mind it going in, but
> I wonder ...
> 
> > Signed-off-by: Julien Grall <julien.grall@xxxxxxxxxx>
> > CC: Keir Fraser <keir@xxxxxxx>
> > CC: Jan Beulich <jbeulich@xxxxxxxx>
> > 
> > ---
> >     Changes in v2:
> >         - Change commit title
> >         - Move the check in init_domheap_pages
> 
> ... who and why suggested to move it here.

Me in response to "xen/arm: Don't call init_domheap_page with an empty
range".

>  After all, I'm considering
> it an error to call the function with non-page-aligned addresses and/
> or end < start (I take it that page-aligned, but start == end is not a
> problem without your change).

Since init_xenheap_page does the right thing it seemed reasonable to me
to make domheap do the same.

Ian,


_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
http://lists.xen.org/xen-devel