Re: [Xen-devel] [PATCH v4 04/17] xen: arm: allocate dom0 memory separately from preparing the dtb

[Ian Campbell <Ian.Campbell@xxxxxxxxxx>]

On Tue, 2013-11-12 at 17:39 +0000, Ian Campbell wrote:
> Mixing these two together is a pain, it forces us to prepare the dtb before
> processing the kernel which means we don't know whether the guest is 32- or
> 64-bit while we construct its DTB.
> 
> Instead split out the memory allocation (including 1:1 workaround handling)
> and p2m setup into a separate phase and then create a memory node in the DTB
> based on the result.
> 
> This allows us to move kernel parsing before DTB setup.
> 
> As part of this it was also necessary to rework where the decision regarding
> the placement of the DTB and initrd in RAM was made. It is now made when
> loading the kernel, which allows it to make use of the zImage/ELF specific
> information and therefore to make decisions based on complete knowledge and do
> it right rather than guessing in prepare_dtb and relying on a later check to
> see if things worked.
> 
> Signed-off-by: Ian Campbell <ian.campbell@xxxxxxxxxx>
> ---

I put this to one side intending to come back and address the review
comments and then forgot. Will update in v5.

Sorry about that!

FWIW I don't think any changes here will invalidate review of other
patches in the series.


_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
http://lists.xen.org/xen-devel