[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index] Re: [Xen-devel] [PATCH v15 08/19] pvh: vmx-specific changes
>>> On 12.11.13 at 16:06, George Dunlap <george.dunlap@xxxxxxxxxxxxx> wrote: > On 11/12/2013 02:03 PM, Jan Beulich wrote: >>>>> On 11.11.13 at 15:57, George Dunlap <george.dunlap@xxxxxxxxxxxxx> wrote: >>> --- a/xen/arch/x86/hvm/vmx/vmcs.c >>> +++ b/xen/arch/x86/hvm/vmx/vmcs.c >>> @@ -28,6 +28,7 @@ >>> #include <asm/msr.h> >>> #include <asm/xstate.h> >>> #include <asm/hvm/hvm.h> >>> +#include <asm/hvm/nestedhvm.h> >> >> Going through the changes below I can't see why you need this, >> and it also looks pretty far off for a PVH related change. > > It's needed for the HVM_CR4_RESERVED_BITS macro, which calls > nestedhvm_enabled(). I couldn't figure out a clean way to include > nestedhvm.h from hvm.h (ran into weird compilation errors), so just gave > up and added it in here. Fine then for now, albeit the proper change would be to move the declaration of nestedhvm_enabled() into hvm.h. Jan _______________________________________________ Xen-devel mailing list Xen-devel@xxxxxxxxxxxxx http://lists.xen.org/xen-devel
|
Lists.xenproject.org is hosted with RackSpace, monitoring our |