Re: [Xen-devel] [PATCH v15 19/19] pvh tools: libxl changes to create a PVH guest.

[Ian Jackson <Ian.Jackson@xxxxxxxxxxxxx>]

George Dunlap writes ("[PATCH v15 19/19] pvh tools: libxl changes to create a 
PVH guest."):
> From: Mukesh Rathor <mukesh.rathor@xxxxxxxxxx>
> 
> Signed-off-by: Mukesh Rathor <mukesh.rathor@xxxxxxxxxx>
> Signed-off-by: George Dunlap <george.dunlap@xxxxxxxxxxxxx>
> Acked-by: Tim Deegan <tim@xxxxxxx>

This looks good to me, assuming that the lower layers do what I think
they do.  I have one style quibble:

> diff --git a/tools/libxl/libxl_create.c b/tools/libxl/libxl_create.c
> index 9d793ba..1442c7b 100644
> --- a/tools/libxl/libxl_create.c
> +++ b/tools/libxl/libxl_create.c
...
> @@ -440,6 +445,14 @@ int libxl__domain_make(libxl__gc *gc, 
> libxl_domain_create_info *info,
>          flags |= XEN_DOMCTL_CDF_hvm_guest;
>          flags |= libxl_defbool_val(info->hap) ? XEN_DOMCTL_CDF_hap : 0;
>          flags |= libxl_defbool_val(info->oos) ? 0 : XEN_DOMCTL_CDF_oos_off;
> +    } else if ( libxl_defbool_val(info->pvh) ) {
...
> +        if ( !libxl_defbool_val(info->hap) ) {

In libxl there should be no spaces inside the if's ( ).

Thanks,
Ian.

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
http://lists.xen.org/xen-devel