[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Xen-devel] [PATCH 1/2] events/fifo: don't spin indefinitely when setting LINK



>>> On 11.11.13 at 17:56, David Vrabel <david.vrabel@xxxxxxxxxx> wrote:
> Still, it seems easy enough to have:
> 
>     for ( try = 0; try < 4; try++ )
>     {
>         ret = try_set_link(word, &w, link);
>         if ( ret >= 0 )
>         {
>             if ( ret == 0 )
>                 clear_bit(EVTCHN_FIFO_BUSY, word);
>             return ret;

Except that I'd recommend implementing this with a switch
entertaining fall-through from case 0 to case 1. But it's your
code, so it's up to you anyway.

Jan


_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
http://lists.xen.org/xen-devel


 


Rackspace

Lists.xenproject.org is hosted with RackSpace, monitoring our
servers 24x7x365 and backed by RackSpace's Fanatical Support®.