Re: [Xen-devel] [PATCH 1/4] opw: libxl: use GCSPRINTF instead of libxl__sprintf

[Ian Campbell <Ian.Campbell@xxxxxxxxxx>]

On Sun, 2013-11-10 at 23:08 -0800, Kelley Nielsen wrote:
> Code cleanup - no functional changes
> 
> The convenience macro GCSPRINTF has been written to be used in place
> of libxl__sprintf(). Replace all calls to libxl__sprintf() in
> libxl_utils.c with invocations of the new macro.
> 
> Signed-off-by: Kelley Nielsen <kelleynnn@xxxxxxxxx>
> Suggested-by: Ian Campbell <Ian.Campbell@xxxxxxxxxx>
> ---
>  tools/libxl/libxl_utils.c | 16 ++++++++--------
>  1 file changed, 8 insertions(+), 8 deletions(-)
> 
> diff --git a/tools/libxl/libxl_utils.c b/tools/libxl/libxl_utils.c
> index 682f874..4841606 100644
> --- a/tools/libxl/libxl_utils.c
> +++ b/tools/libxl/libxl_utils.c
> @@ -173,7 +173,7 @@ int libxl_get_stubdom_id(libxl_ctx *ctx, int guest_domid)
>      int ret;
>  
>      stubdom_id_s = libxl__xs_read(gc, XBT_NULL,
> -                                 libxl__sprintf(gc, 
> "%s/image/device-model-domid",
> +                                 GCSPRINTF("%s/image/device-model-domid",
>                                                 libxl__xs_get_dompath(gc, 
> guest_domid)));

If you reindent this trailing line then:
Acked-by: Ian Campbell <ian.campbell@xxxxxxxxxx>

BTW, it looks like you are going to be resending a few minor revs of
both libxl_qmp.c and libxl_utils.c cleanup. Feel free to put them into a
single overarching "cleanup libxl" series for the resend. I assume it'll
be easier for you and it'll certainly be easier for us
reviewers/committers.

Thanks,
Ian.



_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
http://lists.xen.org/xen-devel