Re: [Xen-devel] [PATCH v14 06/17] pvh: Disable unneeded features of HVM containers

[Tim Deegan <tim@xxxxxxx>]

At 12:14 +0000 on 04 Nov (1383563695), George Dunlap wrote:
> Things kept:
> * cacheattr_region lists
> * irq-related structures
> * paging
> * tm_list
> * hvm params
> 
> Things disabled for now:
> * compat xlation
> 
> Things disabled:
> * Emulated timers and clock sources
> * IO/MMIO io requests
> * msix tables
> * hvm_funcs
> * nested HVM
> * Fast-path for emulated lapic accesses
> 
> Getting rid of the hvm_params struct required a couple other places to
> check for its existence before attempting to read the params.
> 
> Signed-off-by: George Dunlap <george.dunlap@xxxxxxxxxxxxx>
> Signed-off-by: Mukesh Rathor <mukesh.rathor@xxxxxxxxxx>

> @@ -528,10 +536,16 @@ int hvm_domain_initialise(struct domain *d)
>      if ( rc != 0 )
>          goto fail0;
>  
> +    rc = -ENOMEM;
>      d->arch.hvm_domain.params = xzalloc_array(uint64_t, HVM_NR_PARAMS);
> +    if ( !d->arch.hvm_domain.params )
> +        goto fail1;
> +
> +    if ( is_pvh_domain(d) )
> +        return 0;

Doesn't this skip hvm_init_cacheattr_region_list() and
paging_enable(), which are on your list of things to keep for PVH guests?

Tim.

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
http://lists.xen.org/xen-devel