Re: [Xen-devel] [PATCH RESEND 07/12] xen: numa-sched: use per-vcpu node-affinity for actual scheduling

[Dario Faggioli <dario.faggioli@xxxxxxxxxx>]

On mar, 2013-11-05 at 16:20 +0000, George Dunlap wrote:
> On 11/05/2013 02:35 PM, Dario Faggioli wrote:

> > @@ -308,11 +279,9 @@ static void csched_set_node_affinity(
> >   static inline int __vcpu_has_node_affinity(const struct vcpu *vc,
> >                                              const cpumask_t *mask)
> >   {
> > -    const struct domain *d = vc->domain;
> > -    const struct csched_dom *sdom = CSCHED_DOM(d);
> > -
> > -    if (cpumask_full(sdom->node_affinity_cpumask)
> > -         || !cpumask_intersects(sdom->node_affinity_cpumask, mask) )
> > +    if ( vc->auto_node_affinity == 1
> > +         || cpumask_full(vc->node_affinity)
> > +         || !cpumask_intersects(vc->node_affinity, mask) )
> 
> Isn't cpumask_full(vc->node_affinity) <=> vc->auto_node_affinity at this 
> point?
> 
It is. I'd be killing the cpumask_full() part, if it wasn't for the fact
that we decided to re-architect all the thing, and I'm doing the latter
right now.

> Other than that, I think this whole patch looks good -- nice when you 
> can add a feature and simplify the code. :-)
> 
Nice indeed! :-)

Thanks and Regards,
Dario

-- 
<<This happens because I choose it to happen!>> (Raistlin Majere)
-----------------------------------------------------------------
Dario Faggioli, Ph.D, http://about.me/dario.faggioli
Senior Software Engineer, Citrix Systems R&D Ltd., Cambridge (UK)

Attachment: signature.asc
Description: This is a digitally signed message part

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
http://lists.xen.org/xen-devel