Re: [Xen-devel] [PATCH] libxl: Deprecate synchronous waiting for the device model

[Ian Campbell <Ian.Campbell@xxxxxxxxxx>]

On Mon, 2013-10-14 at 17:30 +0100, Ian Jackson wrote:
> diff --git a/tools/libxl/libxl_internal.h b/tools/libxl/libxl_internal.h
> index 165dc00..653079a 100644
> --- a/tools/libxl/libxl_internal.h
> +++ b/tools/libxl/libxl_internal.h
> @@ -1223,7 +1223,19 @@ _hidden int libxl__spawn_record_pid(libxl__gc*, 
> libxl__spawn_state*,
>                                      pid_t innerchild);
>  
>  /*
> - * libxl__wait_for_offspring - Wait for child state
> + * libxl__xenstore_child_wait_deprecated - Wait for daemonic child IPC
> [...]
> This function is currently used only by
> + * libxl__wait_for_device_model_deprecated.

Could it become a static helper in tools/libxl/libxl_device.c (which is
where libxl__wait_for_device_model_deprecated seems to live) then? Tat
would get it out of the internal API immediately...

Ian.



_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
http://lists.xen.org/xen-devel