[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index] Re: [Xen-devel] [PATCH 3 of 5 V3] tools/libxl: setup/teardown Remus network buffering
On Sun, 2013-10-20 at 22:58 -0700, Shriram Rajagopalan wrote: > # HG changeset patch > # User Shriram Rajagopalan <rshriram@xxxxxxxxx> > # Date 1382295266 25200 > # Node ID d3f088236c550213fc04ed982df47b4771b28d2f > # Parent 0001a8222a785865b753acf8bcdf97c10c9e3819 > tools/libxl: setup/teardown Remus network buffering > > Setup/teardown remus network buffering for a given guest, when > libxl_domain_remus_start API is invoked. > > This patch does the following during setup: > a) call the hotplug script for each vif to setup its network buffer > > b) establish a dedicated remus context containing libnl related > state (netlink sockets, qdisc caches, etc.,) > > c) Obtain handles to plug qdiscs installed on the IFB devices > chosen by the hotplug scripts. > > During teardown, the netlink resources are released, followed by > invocation of hotplug scripts to remove the IFB devices. > > Signed-off-by: Shriram Rajagopalan <rshriram@xxxxxxxxx> All this async stuff needs Ian J's eye on it really, not mine. It looks vaguely plausible to my untrained eye. > diff -r 0001a8222a78 -r d3f088236c55 tools/libxl/Makefile > --- a/tools/libxl/Makefile Sun Oct 20 06:12:52 2013 -0700 > +++ b/tools/libxl/Makefile Sun Oct 20 11:54:26 2013 -0700 > @@ -42,6 +42,13 @@ LIBXL_OBJS-y += libxl_blktap2.o > else > LIBXL_OBJS-y += libxl_noblktap2.o > endif > + > +ifeq ($(CONFIG_REMUS_NETBUF),y) > +LIBXL_OBJS-y += libxl_netbuffer.o Should the addition of the libnl stuff to LIBS and CFLAGS have been under here too? > diff -r 0001a8222a78 -r d3f088236c55 tools/libxl/libxl_types.idl > --- a/tools/libxl/libxl_types.idl Sun Oct 20 06:12:52 2013 -0700 > +++ b/tools/libxl/libxl_types.idl Sun Oct 20 11:54:26 2013 -0700 > @@ -539,6 +539,8 @@ libxl_domain_remus_info = Struct("domain > ("interval", integer), > ("blackhole", bool), > ("compression", bool), > + ("netbuf", bool), I guess libxl_defbool doesn't make sense here. > + ("netbufscript", string), This requires a LIBXL_HAVE #define in libxl.h so users know it is available. One for the overall netbuf feature should do I think. Ian. _______________________________________________ Xen-devel mailing list Xen-devel@xxxxxxxxxxxxx http://lists.xen.org/xen-devel
|
Lists.xenproject.org is hosted with RackSpace, monitoring our |