[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Xen-devel] [PATCH v3 01/28] libxl: idl: allow KeyedUnion members to be empty

On Fri, 2013-10-04 at 16:58 +0100, Rob Hoes wrote:
> This is useful when the key enum has an "invalid" option and avoids
> the need to declare a dummy struct. Use this for domain_build_info
> resulting in the generated API changing like so:
>     --- tools/libxl/_libxl_BACKUP_types.h
>     +++ tools/libxl/_libxl_types.h
>     @@ -377,8 +377,6 @@ typedef struct libxl_domain_build_info {
>                  const char * features;
>                  libxl_defbool e820_host;
>              } pv;
>     -        struct {
>     -        } invalid;
>          } u;
>      } libxl_domain_build_info;
>      void libxl_domain_build_info_dispose(libxl_domain_build_info *p);
> + a related change to the JSON generation.
> Signed-off-by: Ian Campbell <ian.campbell@xxxxxxxxxx>
> Signed-off-by: Rob Hoes <rob.hoes@xxxxxxxxxx>
> Acked-by: Ian Jackson <ian.jackson@xxxxxxxxxxxxx>


Enough of the rest of this stuff (at least the stuff early in the
series) was written by me that I think it ought to have an ack from
someone else -- probably Ian J in most cases but for purely ocaml stuff
Dave Scott seems like the guy.

Let this serve as a ping to Ian ;-)


Xen-devel mailing list



Lists.xenproject.org is hosted with RackSpace, monitoring our
servers 24x7x365 and backed by RackSpace's Fanatical Support®.