Re: [Xen-devel] [PATCH 28/29] xentrace: don't try to close null libxc handle in disable_tbufs

[George Dunlap <george.dunlap@xxxxxxxxxxxxx>]

On 30/10/13 07:52, Matthew Daley wrote:
> While at it, simplify the function.
>
> Coverity-ID: 1055316
> Signed-off-by: Matthew Daley <mattjd@xxxxxxxxx>
Reviewed-by: George Dunlap <george.dunlap@xxxxxxxxxxxxx>

> ---
>   tools/xentrace/xentrace.c |    8 ++------
>   1 file changed, 2 insertions(+), 6 deletions(-)
>
> diff --git a/tools/xentrace/xentrace.c b/tools/xentrace/xentrace.c
> index 622bac8..504763d 100644
> --- a/tools/xentrace/xentrace.c
> +++ b/tools/xentrace/xentrace.c
> @@ -425,22 +425,18 @@ fail:
>   static void disable_tbufs(void)
>   {
>       xc_interface *xc_handle = xc_interface_open(0,0,0);
> -    int ret;
>   
>       if ( !xc_handle )
>       {
>           perror("Couldn't open xc handle to disable tbufs.");
> -        goto out;
> +        return;
>       }
>   
> -    ret = xc_tbuf_disable(xc_handle);
> -
> -    if ( ret != 0 )
> +    if ( xc_tbuf_disable(xc_handle) != 0 )
>       {
>           perror("Couldn't disable trace buffers");
>       }
>   
> -out:
>       xc_interface_close(xc_handle);
>   }
>   

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
http://lists.xen.org/xen-devel