Re: [Xen-devel] [PATCH 02/29] libxc: fix retrieval of and remove pointless check on gzip size

[Andrew Cooper <andrew.cooper3@xxxxxxxxxx>]

On 30/10/13 07:51, Matthew Daley wrote:
> Coverity-ID: 1055587
> Coverity-ID: 1055963
> Signed-off-by: Matthew Daley <mattjd@xxxxxxxxx>
> ---
>  tools/libxc/xc_dom_core.c |    4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/tools/libxc/xc_dom_core.c b/tools/libxc/xc_dom_core.c
> index 0f367f6..c9366a9 100644
> --- a/tools/libxc/xc_dom_core.c
> +++ b/tools/libxc/xc_dom_core.c
> @@ -294,8 +294,8 @@ size_t xc_dom_check_gzip(xc_interface *xch, void *blob, 
> size_t ziplen)
>          return 0;
>  
>      gzlen = blob + ziplen - 4;
> -    unziplen = gzlen[3] << 24 | gzlen[2] << 16 | gzlen[1] << 8 | gzlen[0];
> -    if ( (unziplen < 0) || (unziplen > XC_DOM_DECOMPRESS_MAX) )
> +    unziplen = (unsigned int)gzlen[3] << 24 | gzlen[2] << 16 | gzlen[1] << 8 
> | gzlen[0];

This is very minor, but might it be better to cast to size_t, to match
unziplen ?  Either way, the result will now be correct.

~Andrew

> +    if ( unziplen > XC_DOM_DECOMPRESS_MAX )
>      {
>          xc_dom_printf
>              (xch,


_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
http://lists.xen.org/xen-devel