[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index] [Xen-devel] [PATCH 14/29] libxl: don't leak xs_read results in libxl__device_nic_from_xs_be
Coverity-ID: 1055866 Signed-off-by: Matthew Daley <mattjd@xxxxxxxxx> --- tools/libxl/libxl.c | 6 ++++-- 1 file changed, 4 insertions(+), 2 deletions(-) diff --git a/tools/libxl/libxl.c b/tools/libxl/libxl.c index 0b29f32..234f3c1 100644 --- a/tools/libxl/libxl.c +++ b/tools/libxl/libxl.c @@ -2975,9 +2975,10 @@ static void libxl__device_nic_from_xs_be(libxl__gc *gc, tmp = xs_read(ctx->xsh, XBT_NULL, libxl__sprintf(gc, "%s/handle", be_path), &len); - if ( tmp ) + if ( tmp ) { nic->devid = atoi(tmp); - else + free(tmp); + } else nic->devid = 0; /* nic->mtu = */ @@ -2987,6 +2988,7 @@ static void libxl__device_nic_from_xs_be(libxl__gc *gc, rc = libxl__parse_mac(tmp, nic->mac); if (rc) memset(nic->mac, 0, sizeof(nic->mac)); + free(tmp); nic->ip = xs_read(ctx->xsh, XBT_NULL, libxl__sprintf(gc, "%s/ip", be_path), &len); -- 1.7.10.4 _______________________________________________ Xen-devel mailing list Xen-devel@xxxxxxxxxxxxx http://lists.xen.org/xen-devel
|
Lists.xenproject.org is hosted with RackSpace, monitoring our |