[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index] Re: [Xen-devel] [PATCH] fix locking in cpu_disable_scheduler()
>>> On 28.10.13 at 17:24, Andrew Cooper <andrew.cooper3@xxxxxxxxxx> wrote: > One comment however. With the unlock_irqrestore functions, having the > cpu and flags parameters reversed wrt the lock_irqsave looks funny. As > this new interface is still very new, would it be worth moving the flags > parameter to the end of unlock_irqrestore() for consistency ? Actually I intentionally did it this way - the (v)CPU parameter is a helper one only (unused when NDEBUG is defined), and as such didn't seem to be appropriate to be put at a more prominent place. Jan _______________________________________________ Xen-devel mailing list Xen-devel@xxxxxxxxxxxxx http://lists.xen.org/xen-devel
|
Lists.xenproject.org is hosted with RackSpace, monitoring our |