Re: [Xen-devel] [PATCH net V2] xen-netback: use jiffies_64 value to calculate credit timeout

[Wei Liu <wei.liu2@xxxxxxxxxx>]

On Mon, Oct 28, 2013 at 11:49:55AM +0000, Jan Beulich wrote:
> >>> On 28.10.13 at 12:35, Wei Liu <wei.liu2@xxxxxxxxxx> wrote:
> 
> Two formal things:
> 
> > --- a/drivers/net/xen-netback/netback.c
> > +++ b/drivers/net/xen-netback/netback.c
> > @@ -1185,18 +1185,17 @@ out:
> >  
> >  static bool tx_credit_exceeded(struct xenvif *vif, unsigned size)
> >  {
> > -   unsigned long now = jiffies;
> > -   unsigned long next_credit =
> > -           vif->credit_timeout.expires +
> > -           msecs_to_jiffies(vif->credit_usec / 1000);
> > +   u64 now = get_jiffies_64();
> > +   u64 next_credit = vif->credit_window_start +
> > +           (u64)msecs_to_jiffies(vif->credit_usec / 1000);
> 
> The cast to u64 seems pointless here.
> 
> > @@ -1207,7 +1206,8 @@ static bool tx_credit_exceeded(struct xenvif *vif, 
> > unsigned size)
> >             vif->credit_timeout.function =
> >                     tx_credit_callback;
> >             mod_timer(&vif->credit_timeout,
> > -                     next_credit);
> > +                     (unsigned long)next_credit);
> 
> And the cast here seems pointless too (gcc doesn't warn about
> truncations).
> 

Will fix these, thanks.

Wei.

> Jan

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
http://lists.xen.org/xen-devel