[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index] [Xen-devel] [PATCH] libxenstore: Use PTHREAD_STACK_MIN
From: Ian Campbell <ian.campbell@xxxxxxxxxx> The existing value of 16K is smaller than the arm64 minimum stack size, which is 128K. PTHREAD_STACK_MIN appears to be standard http://pubs.opengroup.org/onlinepubs/009695399/functions/pthread_attr_setstacksize.html Consindered setting a lower bound but the stack requirements of the watcher thread are pretty minimal (tens of bytes from the looks of it) and unlikely to blow PTHREAD_STACK_MIN on any useful platform. Signed-off-by: Ian Campbell <ian.campbell@xxxxxxxxxx> Cc: ian.jackson@xxxxxxxxxxxxx --- tools/xenstore/xs.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/tools/xenstore/xs.c b/tools/xenstore/xs.c index b1e6820..261b841 100644 --- a/tools/xenstore/xs.c +++ b/tools/xenstore/xs.c @@ -723,7 +723,7 @@ bool xs_watch(struct xs_handle *h, const char *path, const char *token) struct iovec iov[2]; #ifdef USE_PTHREAD -#define READ_THREAD_STACKSIZE (16 * 1024) +#define READ_THREAD_STACKSIZE PTHREAD_STACK_MIN /* We dynamically create a reader thread on demand. */ mutex_lock(&h->request_mutex); -- 1.8.4.rc3 _______________________________________________ Xen-devel mailing list Xen-devel@xxxxxxxxxxxxx http://lists.xen.org/xen-devel
|
Lists.xenproject.org is hosted with RackSpace, monitoring our |