[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index] Re: [Xen-devel] [PATCH v3-RESEND 03/28] libxl: ocaml: avoid reserved words in type and field names.
On Mon, 2013-10-21 at 14:32 +0100, Rob Hoes wrote: > Do this by adding a "xl_" prefix to all names. Does this not result in pretty fugly looking ocaml code with lots of spurious "xl_" everywhere? > > Signed-off-by: Ian Campbell <ian.campbell@xxxxxxxxxx> > Signed-off-by: Rob Hoes <rob.hoes@xxxxxxxxxx> > > --- > New in v3: > * Using common prefixes rather than changing names on a case by case basis. > --- > tools/ocaml/libs/xl/genwrap.py | 5 ++++- > 1 file changed, 4 insertions(+), 1 deletion(-) > > diff --git a/tools/ocaml/libs/xl/genwrap.py b/tools/ocaml/libs/xl/genwrap.py > index 1b68b6b..a14fcfe 100644 > --- a/tools/ocaml/libs/xl/genwrap.py > +++ b/tools/ocaml/libs/xl/genwrap.py > @@ -70,8 +70,11 @@ def ocaml_type_of(ty): > else: > return ty.rawname > > +def munge_name(name): > + return "xl_" + name > + > def ocaml_instance_of(type, name): > - return "%s : %s" % (name, ocaml_type_of(type)) > + return "%s : %s" % (munge_name(name), ocaml_type_of(type)) > > def gen_ocaml_ml(ty, interface, indent=""): > _______________________________________________ Xen-devel mailing list Xen-devel@xxxxxxxxxxxxx http://lists.xen.org/xen-devel
|
Lists.xenproject.org is hosted with RackSpace, monitoring our |