Re: [Xen-devel] [PATCH] xen/hvc-console: Make it work with HVM guests.

[Ian Campbell <ian.campbell@xxxxxxxxxx>]

On Thu, 2013-10-24 at 17:30 +0100, Julien Grall wrote:

> I'm sure the solution "move xen call earlier" will come up in few mails, 
> so there was a discussion for swiotlb few weeks ago 
> (https://lkml.org/lkml/2013/8/29/609). And the final decision was to 
> avoid specific Xen call in arch_setup.

It wasn't so much a hard reject as a preference based on the need
presented at the time.

Perhaps a generic DT driven mechanism to detect hypervisors, called
early, would be more acceptable?

> Stefano, Ian, any opinion?

The ifdef approach is a bit ugly, but if the other option doesn't work
out I suppose we can live with it.

But stepping back how/why is this function called on x86 when not
running under Xen? Wouldn't the use have to be using console=hvc or
earlyprintk=xen or something -- which strikes me as user error... IOW
can we not just nuke the check

Ian.


_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
http://lists.xen.org/xen-devel