[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index] Re: [Xen-devel] [PATCH 1/7] xen: vNUMA support for PV guests
Hi Elena, Congratulations to your work again!For decrease_reservation, xen will also receive a number of pages. We just free them from domain. Here, we should update the memory size of vnodes and pnodes (I think you keep a counter for the page numbers of each vnode and pnode, something as vnuma_memszs, but please forgive me that you have submitted such a huge patch that I could not understand everything in time : - | ) For populate_physmap, xen will allocate blank pages from its heap for domain guest, from specific nodes, according to the nodemask. Here we should update your counters too! And as I see, we don't have a protocol here on whether the nodemask in (&args ) is pnode or vnode. I think it should be vnode, since guest domain knows nothing about the node affinity. So my idea could be: we communicate with guest domain using vnode IDs. If we need to change the memory size of guest domain, for example, memory increase/decrease on pnode[0], we use your node affinity to change pnode[0] to vnodes_mask, pass it to guest domain. And in the two functions of memory.c mentioned above, we received the vnode_mask, transfer it back to pnode_mask, thus it will work perfectly! And we don't need an extra hypercall for guest domain any more! Elena and Dario, what is your options? -- Yechen Li _______________________________________________ Xen-devel mailing list Xen-devel@xxxxxxxxxxxxx http://lists.xen.org/xen-devel
|
Lists.xenproject.org is hosted with RackSpace, monitoring our |