Re: [Xen-devel] libxl: spawning qemu while files are open

[Ian Campbell <Ian.Campbell@xxxxxxxxxx>]

On Fri, 2013-10-18 at 17:12 +0100, Rob Hoes wrote:
> > On Fri, 2013-10-18 at 15:26 +0000, Rob Hoes wrote:
> > 
> > > We could solve this by opening the suspend-image file in xenopsd using
> > > the O_CLOEXEC flag, causing the file to be closed when executing qemu.
> > > However, we are worried that this behaviour may still cause trouble in
> > > multi-threaded programs such as xenopsd, unless all files it ever
> > > opens are opened with O_CLOEXEC, which is easily forgotten.
> > 
> > I'm afraid this is exactly what you need to do.
> > 
> > libxl itself jumps through considerable hoops to ensure it does this itself,
> > it's extra hard in a library... (have a look= for CLOEXEC in 
> > tools/libxl/*.h for
> > some details)
> 
> Alright, thanks. I'll look into that.

BTW, you might find libxl_fd_set_cloexec helpful...




_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
http://lists.xen.org/xen-devel