Re: [Xen-devel] [PATCH v4 8/9] xen/arm: Implement hypercall for dirty page tracing

[Ian Campbell <Ian.Campbell@xxxxxxxxxx>]

On Fri, 2013-10-18 at 13:17 +0900, Jaeyong Yoo wrote:

> > I meant the pte frobbing immediately before the call the add_mapped_vaddr
> > quoted above.
> > 
> 
> I don't think it is necessary because at the moment the dirty bitmap
> is constructed based on the VAs in the linked list. If the PTE frobbing
> happens
> immediately before add_mapped_vaddr, the corresponding dirty-page would be 
> checked at the next round get-dirty-gitmap. 

OK, thanks. Can we get a code comment on the ordering constraints here
please.

>  
> 
> Now, I start thinking of using bitmap rather than linked list, and I think
> it
> is similar there. The critical section would be the one that writes into the
> bitmap and the one that reads the bitmap (copy to the bitmap from
> toolstack).
> 
> Jaeyong
> 



_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
http://lists.xen.org/xen-devel