[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Xen-devel] [PATCH v4 8/9] xen/arm: Implement hypercall for dirty page tracing

On Fri, 2013-10-18 at 13:17 +0900, Jaeyong Yoo wrote:

> > I meant the pte frobbing immediately before the call the add_mapped_vaddr
> > quoted above.
> > 
> I don't think it is necessary because at the moment the dirty bitmap
> is constructed based on the VAs in the linked list. If the PTE frobbing
> happens
> immediately before add_mapped_vaddr, the corresponding dirty-page would be 
> checked at the next round get-dirty-gitmap. 

OK, thanks. Can we get a code comment on the ordering constraints here

> Now, I start thinking of using bitmap rather than linked list, and I think
> it
> is similar there. The critical section would be the one that writes into the
> bitmap and the one that reads the bitmap (copy to the bitmap from
> toolstack).
> Jaeyong

Xen-devel mailing list



Lists.xenproject.org is hosted with RackSpace, monitoring our
servers 24x7x365 and backed by RackSpace's Fanatical Support®.