Re: [Xen-devel] [PATCH] xen/arm: Add CPU ID for Broadcom Brahma-B15

[Ian Campbell <Ian.Campbell@xxxxxxxxxx>]

On Thu, 2013-10-17 at 16:13 -0700, Marc C wrote:
> Hello Ian,
> 
> > Thanks for resending, I saw the original but somehow failed to add it to
> > my queue of things to look at, sorry!
> 
> No problem. Thanks for taking the time to look at the patch!
> 
> >> +        .long 0x420F00F2             /* Broadcom Brahma-B15 */
> >> +        .long 0xFF0FFFFF             /* Mask */
> >
> > This mask includes the revision field (last nibble). Is it intentional
> > too only support a single revision of this processor?
> 
> Yes. At this time, supporting only this specific version of this CPU
> is required.

Is there any harm in allowing all of them though?

> >> +        .long v7_init
> >
> > v7_init fiddles with the implementation defined ACTLR register in a
> > Cortex-A15/A7 specific manner. Is the B15 compatible with ARM's Cortex
> > A15 in this regard?
> 
> Correct. The B15 will also require the SMP bit to be OR'ed in ACTLR,
> so they can be considered compatible in this regard.
> 
> I could go ahead with refactoring the code in proc-v7.S,

Given the above it's not a requirement so I'll apply this patch as is,
but if you feel inclined to follow up with the refactoring that would be
wonderful.

Thanks,
Ian.



_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
http://lists.xen.org/xen-devel