[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index] Re: [Xen-devel] [PATCH net-next v4 1/5] xen-netback: add support for IPv6 checksum offload to guest
On Mon, 2013-10-14 at 12:10 +0100, Paul Durrant wrote: > > -----Original Message----- > > From: Ian Campbell > > Sent: 14 October 2013 11:54 > > To: Paul Durrant > > Cc: xen-devel@xxxxxxxxxxxxx; netdev@xxxxxxxxxxxxxxx; Wei Liu; David Vrabel > > Subject: Re: [PATCH net-next v4 1/5] xen-netback: add support for IPv6 > > checksum offload to guest > > > > On Fri, 2013-10-11 at 16:06 +0100, Paul Durrant wrote: > > > Check xenstore flag feature-ipv6-csum-offload to determine if a > > > guest is happy to accept IPv6 packets with only partial checksum. > > > Also check analogous feature-ip-csum-offload to determine if a > > > guest is happy to accept IPv4 packets with only partial checksum > > > as a replacement for a negated feature-no-csum-offload value and > > > add a comment to deprecate use of feature-no-csum-offload. > > > > > > Signed-off-by: Paul Durrant <paul.durrant@xxxxxxxxxx> > > > Cc: Wei Liu <wei.liu2@xxxxxxxxxx> > > > Cc: David Vrabel <david.vrabel@xxxxxxxxxx> > > > Cc: Ian Campbell <ian.campbell@xxxxxxxxxx> > > > > Shouldn't this come later in the series, i.e. after netback is actually > > able to cope with ipv6 offloads? > > > > I guess that's debatable. The patches don't have any dependency relation; > offloads to and from the guest are quite independent. > > > > diff --git a/drivers/net/xen-netback/common.h b/drivers/net/xen- > > netback/common.h > > > index 5715318..b4a9a3c 100644 > > > --- a/drivers/net/xen-netback/common.h > > > +++ b/drivers/net/xen-netback/common.h > > > @@ -153,7 +153,8 @@ struct xenvif { > > > u8 can_sg:1; > > > u8 gso:1; > > > u8 gso_prefix:1; > > > - u8 csum:1; > > > + u8 ip_csum:1; > > > + u8 ipv6_csum:1; > > > > Why not ipv4_csum for consistency/unambiguity? > > > > I followed general linux naming conventions e.g. ip_hdr and ipv6_hdr. True. I would be more concerned about the netif.h name, but I think you now intend to drop the v4 variant of that, so no worries. _______________________________________________ Xen-devel mailing list Xen-devel@xxxxxxxxxxxxx http://lists.xen.org/xen-devel
|
Lists.xenproject.org is hosted with RackSpace, monitoring our |