Re: [Xen-devel] [PATCH 2/4] tools: clone ovmf to ovmf-dir directory

[Wei Liu <wei.liu2@xxxxxxxxxx>]

On Wed, Oct 16, 2013 at 10:58:59AM +0100, Jan Beulich wrote:
> >>> On 15.10.13 at 18:40, Wei Liu <wei.liu2@xxxxxxxxxx> wrote:
> > @@ -15,9 +15,9 @@ SUBDIRS-$(CONFIG_ROMBIOS) += vgabios
> >  SUBDIRS-$(CONFIG_ROMBIOS) += etherboot
> >  SUBDIRS-y += hvmloader
> >  
> > -ovmf:
> > -   GIT=$(GIT) $(XEN_ROOT)/scripts/git-checkout.sh $(OVMF_UPSTREAM_URL) 
> > $(OVMF_UPSTREAM_REVISION) ovmf
> > -   cp ovmf-makefile ovmf/Makefile;
> > +ovmf-dir:
> > +   GIT=$(GIT) $(XEN_ROOT)/scripts/git-checkout.sh $(OVMF_UPSTREAM_URL) 
> > $(OVMF_UPSTREAM_REVISION) ovmf-dir
> > +   cp ovmf-makefile ovmf-dir/Makefile;
> 
> If $@ was used in rules like this, you wouldn't have to touch the
> whole rule now (and others wouldn't have to in the future).
> 

I will see what I can do.

Wei.

> Jan

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
http://lists.xen.org/xen-devel